Post submission review:
Used proposal decoder to find proposal actions: action contract for proxy upgrades and a call to the constitution hash contract (the latter is trivial).
Action contract proxy-upgrades and initializes the core governor and the treasury governor to the same new implementation, as well as the ARB token contract to its new implementation.
(Informal) Review:
- Contract now uses OZ Checkpoints to track the total tokens delegated over time; updates with each new delegation. This logic is analogous to the way delegations themselves are tracked.
- There is also a new adjustTotalDelegation setter method callable only by the contract’s owner (DAO / Security Council) which changes the value directly; this is presumably to make future updates that affect delegation logic cleaner, and/or for ease of handling security emergencies.
(Informal) Review:
-
Core Logic for DVP quorum calculation; quorum method now uses total delegated tokens to calculate quorum.
-
Tracks proposer submitters, and exposes cancel method (submitter can cancel).
-
Optional front-running protection against proposal id collisions when submitting a proposal by specifying proposal’s submitter address at end of description.
(Note that while this looks good and sensible and seems tangentially related to cancellation, it isn’t AFAICT specifically mentioned in this proposal’s description.)***(see edit below)
Initialized values (min/max quorums, baseline quorums) match those in the description.
LGTM, voting FOR.
***Edit: I get it now; “front-running” by submitting a proposal with the same ID was previously a non-issue since the proposal ID is deterministically generated from the proposal content and is thus equivalent to simply submitting it. With cancelation, one can grief the submitter by front-running with the equivalent proposal and then cancelling it. This feature is thus a direct implementation detail for cancelation 